[MMB-118] Previous location not set to null for first update #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiatek
force-pushed
the
mmb-118-previousLocation-not-set-to-null-for-first-update
branch
from
1966db5
to
856fa88
Compare
added 3 commits
July 11, 2023 17:05
This fixes a bug where both previousLocation and currentLocation would be set when .set was called initally. When setting location, we'd get a handle on the member and update their location. However, because we called .update on the presence, the subscription on the space would trigger as well, get the location and update the member before we emit the location event.
dpiatek
force-pushed
the
mmb-118-previousLocation-not-set-to-null-for-first-update
branch
from
856fa88
to
0c23203
Compare
artismarti
approved these changes
Jul 11, 2023
artismarti
reviewed
Jul 11, 2023
There was a problem hiding this comment.
The test needs to import the type:
src/LocationTracker.mockClient.test.ts(5,21): error TS2614: Module '"./Locations.js"' has no exported member 'LocationChange'. Did you mean to use 'import LocationChange from "./Locations.js"' instead?
but other than that, looks good.
dpiatek
deleted the
mmb-118-previousLocation-not-set-to-null-for-first-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix initial location being set too eagerly
This fixes a bug where both
previousLocationandcurrentLocationwould be set when .set was called initially.When setting location, we'd get a handle on the member and update their location. However, because we called .update on the presence, the subscription on the space would trigger as well, get the location and update the member before we emit the location event.